Skip to content

chore: refactor time-travel compatibility check#5553

Merged
petebacondarwin merged 3 commits intomainfrom
rozenmd/d1-beta-tweak
Apr 8, 2024
Merged

chore: refactor time-travel compatibility check#5553
petebacondarwin merged 3 commits intomainfrom
rozenmd/d1-beta-tweak

Conversation

@rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Apr 8, 2024

What this PR solves / how to test

Instead of checking for "beta", we should check for alpha.

Author has addressed the following

@rozenmd rozenmd requested review from a team as code owners April 8, 2024 08:23
@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 0a20fb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-wrangler-5553

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5553/npm-package-wrangler-5553

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-wrangler-5553 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-create-cloudflare-5553 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-cloudflare-kv-asset-handler-5553
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-miniflare-5553
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-cloudflare-pages-shared-5553
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8600193705/npm-package-cloudflare-vitest-pool-workers-5553

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.48.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240404.0
workerd 1.20240404.0 1.20240404.0
workerd --version 1.20240404.0 2024-04-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

petebacondarwin
petebacondarwin approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any tests that check this stuff?

@rozenmd
Copy link
Contributor Author

rozenmd commented Apr 8, 2024

There are now @petebacondarwin - btw I think you might need to unlock merging for workers-sdk?

@petebacondarwin petebacondarwin merged commit dcd65dd into main Apr 8, 2024
@petebacondarwin petebacondarwin deleted the rozenmd/d1-beta-tweak branch April 8, 2024 20:25
@workers-devprod workers-devprod mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rozenmd @petebacondarwin